Test for membership should be "not in" #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A linter would yeild an error on the anti-pattern code. Even though it is anti-pattern code, it should demonstrate best practices for everything except the anti-pattern being demonstrated. Although `not 'k' in d` and `'k' not in d` ultimately produce the same bytecode, the former is actually two operations and must be optimized to produce identical bytecode to the latter. The preferred syntax would be `'k' not in d` - per the pep8/flake8 linter. References: - https://github.com/PyCQA/pycodestyle/blob/1.7.0/pep8.py#L1077-L1078 - http://stackoverflow.com/questions/17659303/what-is-more-pythonic-for-not
Member
|
great, thanks @GuyHoozdis ! |
Contributor
Author
|
The Little Book of Python Anti-Patterns is a wonderful resource. It was my pleasure to read and to make this minor contribution. Hopefully, I will be able to contribute more in the future. Until then... |
GuyHoozdis
deleted the
feature/e713-test-for-membershipt-should-be-not-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A linter would yeild an error on the anti-pattern code. Even though it
is anti-pattern code, it should demonstrate best practices for
everything except the anti-pattern being demonstrated.
Although
not 'k' in dand'k' not in dultimately produce the samebytecode, the former is actually two operations and must be optimized to
produce identical bytecode to the latter.
The preferred syntax would be
'k' not in d- per the pep8/flake8linter.
References: