Merged
Conversation
JulesHuisman
requested changes
Nov 21, 2023
Collaborator
JulesHuisman
left a comment
JulesHuisman
left a comment
There was a problem hiding this comment.
Zou kijken of nieuwe tests kunnen gedaan worden door de huidige fixtures. Over het algemeen maak je niet voor alles nieuwe fixtures. Je kan bijvoorbeeld ook een specifieke situatie maken in de test function zelf als het echt nodig is.
Member
Author
|
Ja, vond het zelf ook al niet helemaal mooi. Heb die custom incremental tap die ik had gemaakt nu als de basis genomen voor de fixtures. Die heeft default 2 streams: 1 incremental en 1 full table. Moest idd dan wel ff testen hier en daar wat fixen. |
JulesHuisman
approved these changes
Nov 21, 2023
Collaborator
JulesHuisman
left a comment
JulesHuisman
left a comment
There was a problem hiding this comment.
Nice, dat ziet er een stuk cleaner uit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.