WIP: Add helper for creating modules.#121
Merged
gerrymanoim merged 13 commits intomasterfrom Jun 22, 2020
Merged
Conversation
llllllllll
force-pushed
the
automodule
branch
2 times, most recently
from
9e303af to
db8bfec
Compare
llllllllll
changed the title
The created modules help ensure that `import_array` and `py::abi::ensure_compatible_libpy_abi()` are called correctly. This wrapper also guards against C++ exceptions being thrown in the module init. The wrapper also manages many Python 2/3 compatibility issues.
Contributor
|
@llllllllll - I removed the py2 compat code and rebased this branch against master, but I'm confused about what the state of the |
Contributor
|
Note for myself, tests seem to be getting python2.7? I probably messed up the makefile merge. TODO: investigate the clang sadness. |
Contributor
|
Weirdly tests now fully pass locally (in gcc) |
Contributor
|
I had trouble getting the list to work - open to ideas. |
Contributor
|
Note:
|
llllllllll
commented
Jun 22, 2020
added 2 commits
June 22, 2020 17:16
llllllllll
commented
Jun 22, 2020
llllllllll
commented
Jun 22, 2020
llllllllll
commented
Jun 22, 2020
llllllllll
commented
Jun 22, 2020
added 3 commits
June 22, 2020 17:42
llllllllll
pushed a commit
that referenced
this pull request
Jun 23, 2020
* ENH: Add helper for creating modules. The created modules help ensure that `import_array` and `py::abi::ensure_compatible_libpy_abi()` are called correctly. This wrapper also guards against C++ exceptions being thrown in the module init. The wrapper also manages many Python 2/3 compatibility issues. Co-authored-by: Gerry Manoim <gmanoim@quantopian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The created modules help ensure that
import_arrayandpy::abi::ensure_compatible_libpy_abi()are called correctly.This wrapper also guards against C++ exceptions being thrown in the module init.
The wrapper also manages many Python 2/3 compatibility issues.