BUG: Update from_object dispatch for table#151
Merged
richafrank merged 2 commits intomasterfrom May 28, 2020
Merged
Conversation
richafrank
force-pushed
the
table-from-object
branch
from
ee0cd36 to
66ca063
Compare
Contributor
|
Can you add a test in table or from object to make sure we don't break these again? |
Contributor
Author
|
Will do. |
richafrank
force-pushed
the
table-from-object
branch
2 times, most recently
from
6250653 to
9d627ab
Compare
llllllllll
reviewed
May 26, 2020
Contributor
llllllllll
left a comment
llllllllll
left a comment
There was a problem hiding this comment.
lgtm, just had some style questions
| ifeq ($(COMPILER),GCC) | ||
| # #sparseahash uses realloc which osx+gcc are not happy about | ||
| CXXFLAGS += -Wno-class-memaccess | ||
| GCCVERSIONLT9 := $(shell expr `$(COMPILER) -dumpversion | cut -f1 -d.` \< 9) |
to use borrowed_ref, which is the new expected interface
to prevent "Symbol not found"
richafrank
force-pushed
the
table-from-object
branch
from
b05fb49 to
ba84f00
Compare
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to use borrowed_ref, which is the new expected interface