Skip to content

BLD: Add release drafter flow#158

Merged
gerrymanoim merged 1 commit intomasterfrom
release-drafter
Jun 23, 2020
Merged

BLD: Add release drafter flow#158
gerrymanoim merged 1 commit intomasterfrom
release-drafter

Conversation

@gerrymanoim
Copy link
Copy Markdown
Contributor

No description provided.

@gerrymanoim gerrymanoim requested a review from llllllllll June 23, 2020 16:18
@llllllllll
Copy link
Copy Markdown
Contributor

Do we really want a new release on each merge?

@gerrymanoim
Copy link
Copy Markdown
Contributor Author

It just appends the changes to a draft - you still have to manually click the publish button to tag+publish the release.

For trading-calendars we just let the changes stack until it we need to release.

Here's a current active draft: https://github.com/quantopian/trading_calendars/releases/tag/untagged-04b02885dcb2318302cb

The pypi flow runs after you actually publish a release.

@llllllllll
Copy link
Copy Markdown
Contributor

I see, I wasn't sure how this worked. LGTM

@gerrymanoim gerrymanoim merged commit 10e0f02 into master Jun 23, 2020
@gerrymanoim gerrymanoim deleted the release-drafter branch June 23, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants