DOC: Use automodule in tutorial #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually breaks for me locally. We aren't checking if docs can be built as part of our tests. |
llllllllll
reviewed
Jun 24, 2020
| LIBPY_AUTOMODULE(libpy_tutorial, classes, ({})) | ||
| (py::borrowed_ref<> m) { | ||
| py::owned_ref t = | ||
| py::autoclass<vec3d>("classes.Vec3d") |
There was a problem hiding this comment.
I don't love that classes is duplicated. What about `PyModule_GetName(m) + ".Vec3d"?
Also, or in addition, maybe we should make some helper to set the proper path and add the type without needing the cast.
added 7 commits
June 25, 2020 17:11
gerrymanoim
force-pushed
the
automodule-tutorial
branch
from
03f122c to
2105f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.