BUG: Put initialization of perf_tracker back in __init__ #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good. Could use a unittest so that the bug doesn't resurface. |
Contributor
Author
|
Yep, first on my list for today. |
Contributor
Author
|
Should be ready to go. |
Contributor
|
Looks good. Have you confirmed that the test fails without the fix? |
Contributor
Author
|
Yup it fails w/o the change. |
Contributor
|
Cool, thanks for checking. /signoff |
Contributor
Author
|
I just realized, might it be better to remove the else statement and always assign it? sim_params are going to be initialized at that point in the code anyway. |
Contributor
|
@CaptainKanuk Yes, that's a good point. /sign-off |
The initialization of perf_tracker had been moved from __init__ in TradingAlgorithm to _create_generator. This caused perf_tracker to not be ready when portfolio requested it. portfolio was consequently not ready for access in init. portfolio can now be accessed in init again, assuming valid sim_params are passed. Otherwise it will be available in handle_data() after _create_generator() is called.
CaptainKanuk
added a commit
that referenced
this pull request
Jul 21, 2014
BUG: Put initialization of perf_tracker back in __init__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization of perf_tracker had been moved from init
in TradingAlgorithm to _create_generator. This caused perf_tracker
to not be ready when portfolio requested it. portfolio was consequently
not ready for access in init. portfolio can now be accessed in init
again, assuming valid sim_params are passed. Otherwise it will be
available in handle_data().