Various changes and fixes #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SergeyRuzin
commented
Sep 22, 2021
SergeyRuzin
commented
- Made log for failed table binding more readable
- Added sample feature which does not require deployed demo app
- Fixed enabled check inverted log
- Changed package-lock dependencies to fix github alerts
SergeyRuzin
requested review from
Brrovko,
Georgiy-Petrov-Quantori,
valeriyKhoroshun and
vladimir-s-quantori
vladimir-s-quantori
requested changes
Sep 22, 2021
| public static string GetPrintableValues(this IEnumerable<ITableRowWrapper> rows) | ||
| { | ||
| return rows.SelectMany(x => x.CellsText).Aggregate((x, y) => $"{x}, {y}"); | ||
| var values = rows.Aggregate("\r\n|", (current, row) => current + (row.CellsText.Aggregate((x, y) => $" {x} | {y}") + " |\r\n |")); |
Collaborator
There was a problem hiding this comment.
Aggregate method doesn't apply to empty or null collections and will throw exception in this case. I guess we should check rows for null/empty and throw a readable exception or empty string in this case
Contributor
Author
There was a problem hiding this comment.
Added check which returns "Row collection is empty" string
vladimir-s-quantori
previously approved these changes
Sep 22, 2021
Brrovko
previously approved these changes
Sep 27, 2021
Brrovko
approved these changes
Sep 27, 2021
vladimir-s-quantori
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.