BAP-69 Added dropdown binding with multiple contain check #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRuzin
requested review from
Brrovko,
Georgiy-Petrov-Quantori and
vladimir-s-quantori
Brrovko
reviewed
Oct 19, 2021
| CheckDropdownElements(wrapper.GroupTexts, items, $"{wrapper.Caption} groups"); | ||
| } | ||
|
|
||
| [When("(.*?) (contain|not contain) \"(.*)\"")] |
Contributor
There was a problem hiding this comment.
Are you sure we don't have scenarios with the "when" step?
Contributor
Author
There was a problem hiding this comment.
Since this check in "when" step violates Gherkin syntax a bit, I think we don't have such scenarios. But I'll check
Contributor
Author
There was a problem hiding this comment.
I cannot find any usages of this step with "when". Seems ok to remove it
Brrovko
previously approved these changes
Oct 20, 2021
ILastovka
previously approved these changes
Oct 21, 2021
vladimir-s-quantori
approved these changes
Oct 26, 2021
Brrovko
approved these changes
Oct 27, 2021
ILastovka
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.