Skip to content

EnvCommand confirmation#107

Merged
andrey-smaelov merged 5 commits into
quantum-php:masterfrom
hatik92:master
Dec 1, 2022
Merged

EnvCommand confirmation#107
andrey-smaelov merged 5 commits into
quantum-php:masterfrom
hatik92:master

Conversation

@hatik92

@hatik92 hatik92 commented Nov 30, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@hatik92 hatik92 requested a review from armanist November 30, 2022 11:51
@codecov

codecov Bot commented Nov 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #107 (12f525a) into master (7268d67) will decrease coverage by 0.31%.
The diff coverage is 4.76%.

@@             Coverage Diff              @@
##             master     #107      +/-   ##
============================================
- Coverage     70.92%   70.61%   -0.32%     
- Complexity     1691     1701      +10     
============================================
  Files           146      146              
  Lines          4004     4022      +18     
============================================
  Hits           2840     2840              
- Misses         1164     1182      +18     
Impacted Files Coverage Δ
src/Console/Commands/EnvCommand.php 0.00% <0.00%> (ø)
src/Console/Commands/KeyGenerateCommand.php 0.00% <0.00%> (ø)
src/Console/QtCommand.php 0.00% <0.00%> (ø)
src/Environment/Environment.php 81.57% <16.66%> (-12.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread src/Console/Commands/EnvCommand.php Outdated
{
if (file_exists('.env.example')) {
if (!$this->getOption('yes')) {
if (file_exists('.env')) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use FileSystem::exists() method instead

@armanist armanist self-requested a review December 1, 2022 09:59
Comment thread src/Console/Commands/EnvCommand.php Outdated
if (file_exists('.env.example')) {
if (!$this->getOption('yes')) {
if (file_exists('.env')) {
$message = "The operation will overwrite values of the existing .env create new one from .env.example. Continue?";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message: ... existing .env and will create ...

@armanist armanist self-requested a review December 1, 2022 13:15
@andrey-smaelov andrey-smaelov merged commit 796adbb into quantum-php:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants