Ability to use 3rd party email service#128
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
============================================
- Coverage 70.33% 69.80% -0.54%
- Complexity 1735 1747 +12
============================================
Files 147 149 +2
Lines 4396 4434 +38
============================================
+ Hits 3092 3095 +3
- Misses 1304 1339 +35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
armanist
requested changes
Jan 31, 2023
| $this->mailer->AllowEmpty = true; | ||
| $this->mailer->isHTML(true); | ||
| } elseif (config()->get('mailer')['current'] == 'sendinblue') { | ||
| $this->api_key = config()->get('mailer')['sendinblue']['api_key']; |
Collaborator
There was a problem hiding this comment.
Use dot access instead of array access
| return $sent; | ||
| } else { | ||
| return $this->mailer->send(); | ||
| $this->htmlContent = $body; |
Collaborator
There was a problem hiding this comment.
What is the meaning of the property $htmlContent ?
| $this->mailer->Port = config()->get('mail_port'); | ||
| $this->mailer->Username = config()->get('mail_username'); | ||
| $this->mailer->Password = config()->get('mail_password'); | ||
| $this->mailer->Host = config()->get('mailer')['default']['mail_host']; |
Collaborator
There was a problem hiding this comment.
Use dot access everywhere
armanist
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.