Adding Mailgum mailer#130
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
============================================
- Coverage 69.81% 69.18% -0.64%
- Complexity 1747 1754 +7
============================================
Files 149 151 +2
Lines 4436 4481 +45
============================================
+ Hits 3097 3100 +3
- Misses 1339 1381 +42
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
armanist
requested changes
Feb 16, 2023
| class MailgunAdapter implements MailerInterface | ||
| { | ||
| /** | ||
| * Send mail by using Sendinblue |
| ->setData($data) | ||
| ->start(); | ||
| return true; | ||
| dd($httpClient); |
| return true; | ||
| dd($httpClient); | ||
| } catch (\Exception $e) { | ||
| dd($e); |
| 'mail_trap' => true, | ||
|
|
||
| 'smtp' => [], | ||
| 'smtp' => [ |
Collaborator
There was a problem hiding this comment.
why mail_trap moved to smtp section?
armanist
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.