Added ZipArchive class#131
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
============================================
+ Coverage 68.72% 69.27% +0.55%
- Complexity 1757 1867 +110
============================================
Files 152 156 +4
Lines 4511 4810 +299
============================================
+ Hits 3100 3332 +232
- Misses 1411 1478 +67
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Adding PharArchive class and tests
armanist
requested changes
Mar 13, 2023
| public function deleteMultipleFilesUsingName(array $fileNames): bool | ||
| { | ||
| try { | ||
| $newPhar = new Phar($this->archiveName); |
Collaborator
There was a problem hiding this comment.
new Phar instantiation should be moved to constructor
armanist
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.