Two step verification feature(more changes)#35
Merged
Conversation
armanist
requested changes
Feb 10, 2021
|
|
||
| $tokens = $this->setUpdatedTokens($user); | ||
|
|
||
| return $tokens; |
Collaborator
There was a problem hiding this comment.
The expression return $otp_token returns the type string which is incompatible with the documented return type array.
| $user = $this->authService->get($this->keys['otpToken'], $otp_token); | ||
|
|
||
| if (new \DateTime() >= new \DateTime($user[$this->keys['otpExpiryIn']])){ | ||
| throw new AuthException(ExceptionMessages::VERIFICATION_CODE_EXPIRY_IN); |
Collaborator
There was a problem hiding this comment.
The constant Quantum\Exceptions\ExceptionMessages::VERIFICATION_CODE_EXPIRY_IN was not found.
|
|
||
| $this->towStepVerification($mailer, $user, $otp_expiry_time, $otp_token); | ||
|
|
||
| return $otp_token; |
Collaborator
There was a problem hiding this comment.
The expression return $otp_token returns the type string which is incompatible with the documented return type boolean.
|
|
||
| $user = (array) $this->user(); | ||
| if (new \DateTime() >= new \DateTime($user[$this->keys['otpExpiryIn']])){ | ||
| throw new AuthException(ExceptionMessages::VERIFICATION_CODE_EXPIRY_IN); |
Collaborator
There was a problem hiding this comment.
The constant Quantum\Exceptions\ExceptionMessages::VERIFICATION_CODE_EXPIRY_IN was not found.
armanist
approved these changes
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.