Skip to content

postTransform changes#87

Merged
armanist merged 5 commits into
quantum-php:masterfrom
hatik92:master
Jan 31, 2023
Merged

postTransform changes#87
armanist merged 5 commits into
quantum-php:masterfrom
hatik92:master

Conversation

@hatik92

@hatik92 hatik92 commented Jan 20, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@hatik92 hatik92 requested a review from armanist January 20, 2023 15:40

@armanist armanist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test are not passed

Comment thread shared/Commands/DemoCommand.php Outdated
}

$this->runExternalCommand(self::COMMAND_MIGRATE, ['direction' => 'down']);
$this->runExternalCommand(self::COMMAND_MIGRATE, ['direction' => 'down', '--yes' => 'yes']);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be '--yes' => true ?

@hatik92 hatik92 requested a review from armanist January 30, 2023 13:53
@armanist armanist merged commit 2864eac into quantum-php:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants