Fix viz #106
Merged
Fix viz #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-visualizer-files Add visualization library to CMake build
LalehB
approved these changes
Aug 14, 2025
| if not list_part: | ||
| return [] | ||
| return [int(x.strip()) for x in list_part.split(',') if x.strip()] | ||
| # Be tolerant: accept "1, 2, 3" or "1 2 3" |
Contributor
Author
|
Yes! It would be good to refactor so the visualization code is part of the main source tree and tested properly |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changed the error format:
33bff52
This broke the visualizer. Here we fix the visualizer for compatibility with the new error printing format.