-
Notifications
You must be signed in to change notification settings - Fork 18
Refactor/rename num detectors to num dets #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-visualizer-files Add visualization library to CMake build
…-and-fix-cmake-tests Fix CMake Python module path and add agent build instructions
…accept-bitstring Allow decode_to_errors to accept bitstring
Co-authored-by: Noureldin <noureldinyosri@gmail.com>
…date-tesseract Add explicit DetIndex branch for detector ordering
…ers-and-build_det_orders refactor detector order helpers
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
69c841f to
a1e86a7
Compare
…ithub.com/quantumlib/tesseract-decoder into refactor/rename-num_detectors-to-num_dets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_detectors doesn't really make as much sense to me as a variable name since we're actually referring to the number of activated detectors which we may as well abbreviate dets