Fixing -DNDEBUG handling in HiGHS dependency
#35
Merged
+181
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange Fix typo in README
Fix Bazel build on Linux
…s-in-src/common.cc Fix zero-probability handling
…cument-changes Add configurable test modes
…and-tesseract-decoder Add docs links to README
…ing-algorithm Add BFS detector ordering option
…dex.html-for-default-visualizatio Add BFS detector coordinate logging
Add the default logfile for the visualizer
…rning Silence unused model_status warning
… via customized build file
LalehB
approved these changes
Jun 17, 2025
Collaborator
LalehB
left a comment
LalehB
left a comment
There was a problem hiding this comment.
LGTM!
Thanks Noah for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we set
-DNDEBUGdefine globally in the.bazelrc. This is because HiGHS is 1.6x slower if compiled with assertions. However, this also disables assertions in Tesseract and Simplex user code. A better approach is taken here where we compile HiGHS library with a custom BUILD that adds the-DNDEBUG