[Fix #143] Properly handling Optional variable #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
Fix_#143
branch
3 times, most recently
from
f98eaa1 to
19a03be
Compare
melloware
approved these changes
Jun 25, 2025
fjtirado
commented
Jun 25, 2025
|
|
||
| @Test() | ||
| public void waitStartup() { | ||
| Assertions.fail("Expected failure to check startup timeout exception"); |
Contributor
Author
There was a problem hiding this comment.
This assertion was wrong, causing the test to behave randomly
We want to check that the timeout is properly set, so quarkus should receive the IO (which is guaranted by the setExpectedException) and the test should suceeed, not fail
Contributor
Author
There was a problem hiding this comment.
I disable the test, it is inherently flaky due to the usage of arbitrary timeout. In my local, setting it to 1 ms always worked, but in CI it always failed (effect what I achieve in my local by setting it to 10000ms, which makes sense, there is not exception since the db has time to start and when setting it to 1ms there should be an exception since DB will take more than that to startup)
fjtirado
force-pushed
the
Fix_#143
branch
2 times, most recently
from
133a1b9 to
4e507a6
Compare
ricardozanini
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.