feat: support named log filter #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquinio1A
force-pushed
the
feature/filter
branch
from
4af5a6b to
7244301
Compare
Contributor
|
Question: why is the new configuration entry Optional<String> and not Optional<List<String>>? Is it not possible to plug multiple filters? |
Member
Author
The JUL API only supports one (https://docs.oracle.com/en/java/javase/21/docs/api/java.logging/java/util/logging/Handler.html#setFilter(java.util.logging.Filter) so I guess that's why Quarkus handlers did the same. |
Some logic has to be duplicated from LoggingResourceProcessor/LoggingSetupRecorder due to lack of build items. Also Quarkus core registers a global LogCleanupFilter after named handlers initialization, so we need to implement #setFilter rather as an #addFilter.
Contributor
|
Seems good for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244
Some logic has to be duplicated from LoggingResourceProcessor/LoggingSetupRecorder due to lack of build items.
Also Quarkus core registers a global LogCleanupFilter after named handlers initialization, so we need to implement #setFilter rather as an #addFilter.