fix: add option to disable printing log events to stdout #351
Conversation
Introduces a new configuration option to disable the printing of log events to stdout when a communication error with splunk occurs. This is useful in scenarios where applications manages sensitive data such as PCI, PII or security token. Also fix issue build by adding a asciidoctorj-diagram-plantuml dependency due to asciidoctorj-diagram to 3.0.1
|
|
||
| ifdef::add-copy-button-to-env-var[] | ||
| Environment variable: env_var_with_copy_button:+++QUARKUS_LOG_HANDLER_SPLUNK_MIDDLEWARE+++[] | ||
| Environment variable: env_var_with_copy_button:+++QUARKUS_LOG_HANDLER_SPLUNK_PRINT_EVENTS_TO_STDOUT_ON_ERROR+++[] |
There was a problem hiding this comment.
We could have the impression that I am overriding the documentation of QUARKUS_LOG_HANDLER_SPLUNK_MIDDLEWARE but in fact QUARKUS_LOG_HANDLER_SPLUNK_MIDDLEWARE documentation was duplicated
There was a problem hiding this comment.
I just can't find QUARKUS_LOG_HANDLER_SPLUNK_MIDDLEWARE in the new version.
There was a problem hiding this comment.
this is automatically generated, i.e. if one forgot to run mvn clean install before committing, we might have discrepances
| * Formatted using console handler settings if the console handler is enabled | ||
| * Formatted using splunk handler settings otherwise | ||
|
|
||
| It is recommended to disable this feature for applications dealing with sensitive data, as logs might contain sensitive information. |
There was a problem hiding this comment.
I think it would make sense to add the property to set in order to disable the feature
|
|
||
| ifdef::add-copy-button-to-env-var[] | ||
| Environment variable: env_var_with_copy_button:+++QUARKUS_LOG_HANDLER_SPLUNK_MIDDLEWARE+++[] | ||
| Environment variable: env_var_with_copy_button:+++QUARKUS_LOG_HANDLER_SPLUNK_PRINT_EVENTS_TO_STDOUT_ON_ERROR+++[] |
There was a problem hiding this comment.
this is automatically generated, i.e. if one forgot to run mvn clean install before committing, we might have discrepances
5 participants
Introduces a new configuration option to disable the printing of log events to stdout when a communication error with splunk occurs.
This is useful in scenarios where applications manages sensitive data such as PCI, PII or security token.
Also fix issue build by adding a asciidoctorj-diagram-plantuml dependency due to asciidoctorj-diagram to 3.0.1