Skip to content

Conversation

@mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 30, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

🙈 The PR is closed and the preview is expired.

@mkouba mkouba force-pushed the quarkus-component-test branch 3 times, most recently from 550ed40 to 148ebc9 Compare July 3, 2023 13:50
@mkouba mkouba marked this pull request as ready for review July 3, 2023 14:19
@Ladicek
Copy link
Contributor

Ladicek commented Jul 3, 2023

Nice! The only thing I don't really like is how QuarkusComponentTestExtension is mentioned a few times before the section "Advanced features", which makes it a bit harder to comprehend.

Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
Co-authored-by: Ladislav Thon <ladicek@gmail.com>
@mkouba mkouba force-pushed the quarkus-component-test branch from b6d6f5f to e1d82ea Compare July 3, 2023 15:31
@mkouba
Copy link
Contributor Author

mkouba commented Jul 3, 2023

Nice! The only thing I don't really like is how QuarkusComponentTestExtension is mentioned a few times before the section "Advanced features", which makes it a bit harder to comprehend.

Yeah, I know. I've modified the example code so that it's clear that the @QuarkusComponentTest registers the QuarkusComponentTestExtension... it's not optimal but hopefully a little bit better.

@mkouba
Copy link
Contributor Author

mkouba commented Jul 3, 2023

Thanks @gastaldi for all your comments! 👍

@gsmet gsmet merged commit 141bffd into quarkusio:develop Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants