Fix yaml-tags non-deterministic write#1
Merged
Conversation
The yaml-tags snapshot test failed intermittently because Path/Glob/Expr ConfigValue variants created temporary Inlines during serialization. When these temporaries were dropped, their memory addresses could be reused by subsequent allocations, causing the SourceInfoSerializer's pointer cache to return incorrect IDs. Fix by pre-serializing all Path/Glob/Expr ConfigValues at the start of write_pandoc(). This ensures their SourceInfos are interned first, before any temporary allocations can cause memory reuse issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cscheid
changed the title
shikokuchuo
added a commit
that referenced
this pull request
May 12, 2026
Replace the Phase 0 unimplemented!() bodies with the real impls: AttributionDataBuilder interns actors once and Arc::clone-s thereafter; AttributionMap::query_byte_range uses partition_point + a forward walk to pick the most-recent overlapping run; PreBuiltAttributionProvider:: build re-interns through the builder so transport JSON round-trips restore Arc<str> ptr-equality; format_supports_attribution matches FormatIdentifier::Html (covers html, q2-debug, extension HTML); from_config_value reads meta.attribution.identities into an IdentityMap with fresh Arc keys so Phase 2's merge can preserve provider keys on collision. Turns Phase 0 tests #1 + #2 (10 cases) green; the 8 regression pins stay green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're attempting to isolate a yaml-tags nondeterministic snapshot.