ui(replay-drawer): rename Authorship pill to Authors + tighten its affordance#224
Merged
Conversation
Visible string + aria-label only; internal vocabulary (component name, props, CSS classes, test describe block) still says authorship and is slated for unification with attribution in a follow-up.
Pure rename across the UI surface (component, props, CSS classes,
keyframes, custom properties, test descriptions, comments) so the
internal vocabulary matches the data API and the contract doc.
User-facing strings ("Authors" pill label, "Authors overlay"
aria-label, "Highlight authors" tooltip) are unchanged.
The pill was rendering for every file type but only `q2-debug` and `q2-preview` actually surface attribution visually — toggling it for other formats did nothing the user could see. Now the pill greys out with an explanatory title when `currentFormat` is anything else. `attributionOn` state is preserved across the disabled period so returning to a supported format restores the user's preference.
Replaces the static "Highlight authors" tooltip with "Show authors
overlay" / "Hide authors overlay" depending on the on/off state, so
the noun-phrase matches the disabled-state message ("Authors overlay
is not available for this format") and the verb tracks what clicking
will actually do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Four changes to the "Authors" pill (formerly "Authorship"):
Authorship/authorship→Attribution/attributionacross components, props, CSS classes, keyframes, and tests. Pure rename, no behaviour change.q2-debugorq2-preview— the only formats that surface attribution visually. The user'sattributionOnpreference is preserved across the disabled period."Show authors overlay"/"Hide authors overlay"/"Authors overlay is not available for this format", so the noun-phrase is consistent and the verb tracks what clicking will do.Why
Naming was inconsistent (internal
authorshipvs APIattributionvs visible "Authorship"), the pill rendered for every file format even when toggling it did nothing the user could see, and the tooltip didn't track state. This collapses the naming to two layers (attributioninternally,Authorsuser-facing) and tightens the pill's affordance.