Add support for using Microsoft Edge instead of Chrome on Windows #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #972
HKCR: Command line argument where returned and we need only program path.I tested interactively on my Windows 11 using default Diagram example of Quarto (https://quarto.org/docs/authoring/diagrams.html)
I did not add that yet, but we probably would like to add tests specific for Windows for this part of the code.
@cscheid do you think it would be a good idea to add a check to
http://localhost:<remote_port>/json/versionfor a minimal version requirement ?Also, for this MSEDGE feature, I am just wondering how to handle possible older version of EDGE if we want to fail on them gracefully. I would need to find an old Windows system to test that.