(brand.yml) sass - create explicit sass cache object, use deno.kv
#10218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(To avoid another big merge issue, this time we'll be doing tons of small PRs against
main)This PR adds an explicit
SassCacheclass and uses Deno KV (locally) to manage the mapping of hashes. This should not have any present performance impacts, but will make it so that it's safe for future versions of Quarto to parallelize multiple calls against this cache. In addition, we explicitly manage and check the version of the cache stored in disk, so that future changes that cause backwards incompatibility will have a safe upgrade path.