Resolve inputs files in the order of the render list

[cderv]

Using Promise.all() with current addFile() logic without keeping track of index does not allow us to comply with render list order

This creates various problem, including breaking the promise of render target config controlling the order of rendering.

• fixes Can't control the render order on GitHub Actions ubuntu-latest #10463
• fixes render --to pdf and render --to docx has image path problems while render --to html works #11039
• fixes Quarto does not preserve the render order mentioned in _quarto.yaml #10714

Creating this as a Draft PR for now to discuss, and see if we can keep the Promise logic for performance while keeping track of the order

[cderv]

see if we can keep the Promise logic for performance while keeping track of the order

Second commit is modifying addFile() and addDir() logic so that order of render target is respected, while benefiting of asynchronous engine resolution that I believe was part of the purpose of #8787

I am now looking to add test for this

[cderv]

I am now looking to add test for this

Not sure that is a reliable way though... 🤔

[cscheid]

Very cool, thanks for taking this on.

I remember this bit of code very well, because @dragonstyle and I had a large number of attempts to fix this at some point around 1.5.

We definitely need to fix this, but I want to be very careful around it, especially since (as you've noted) this is currently pretty hard to test.

[cscheid]

What if we split the logic into two steps, one that enumerates all of the files in the correct order, and another that filters out the files from the original enumeration?

[cderv]

Let's close this in favor of #11062