ProjectContext - take responsibility over engine determination and markdown resolution #8787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkdown resolution
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way Markdown is resolved and stored throughout Quarto.
Now that a presence of a ProjectContext file is guaranteed, we can give ProjectContext the responsibility to resolve the "full markdown" of a document. The "full markdown" of a document is the result of expanding all include shortcodes.
Previously, our engine determination was in a bit a mess where we had complicated logic to determine what the engine was supposed to be. In addition, because we had no single source of truth for that, we had different logic in different code paths, and we could not take advantage of caching.
This PR makes it so that include shortcodes are resolved before engine determination. For each markdown file, engine determination is then only performed once (and cached at the ProjectContext object). This simplifies the logic, increases performance, cleans up the code and fixes bugs.
This closes #8779 and part of #8563.