Skip to content

Conversation

@cscheid
Copy link
Collaborator

@cscheid cscheid commented Jun 8, 2022

This introduces src/vendor in addition to src/resources/vendor and a new "merged" import map that we can use during development. Most importantly, this should make it so that CI doesn't need to touch skypack. Every time src/import_map.json or src/resources/vendor/import_map.json changes, our configure scripts should revendor everything necessary, as well as recreate the merged import map.

There are a few things to decide on:

  • What's the best name for the new import map?
  • Should we rm the old vendored dependencies or mv them to a temporary spot like I did? I'd prefer not risk a shell script bug rm -rfing more than necessary.

@cscheid
Copy link
Collaborator Author

cscheid commented Jun 8, 2022

(It's really hilarious that this failed because somehow we're still going to the web and so the 500 error appeared here. It's gotten so bad that it might as well be deterministic)

@cscheid cscheid merged commit 5bfd772 into main Jun 9, 2022
@cscheid cscheid deleted the feature/deno-vendor branch June 9, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants