-
Notifications
You must be signed in to change notification settings - Fork 390
Vendor all dependencies into our version control #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
(It's really hilarious that this failed because somehow we're still going to the web and so the 500 error appeared here. It's gotten so bad that it might as well be deterministic) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
src/vendorin addition tosrc/resources/vendorand a new "merged" import map that we can use during development. Most importantly, this should make it so that CI doesn't need to touch skypack. Every timesrc/import_map.jsonorsrc/resources/vendor/import_map.jsonchanges, our configure scripts should revendor everything necessary, as well as recreate the merged import map.There are a few things to decide on:
rmthe old vendored dependencies ormvthem to a temporary spot like I did? I'd prefer not risk a shell script bugrm -rfing more than necessary.