py-shiny - Use explicit = syntax for option #12093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, `quarto preview` does not work on Windows as quoting is not enough to avoid shell expension pallets/click#2359 Could be revisited if shiny for python opt-out shell expansion
[skip ci]
|
This is a good fix, thanks. We should really try to avoid shell expansion anywhere we possibly can. |
Totally ! For context, I discussed this with @gadenbuie - this is not expected really, it is specific to Windows due to how the CLI tool used in Python for py-shiny works. For reference, Ideally, shiny for Python should probably opt-out this default shell expansion on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
quarto previewdoes not work on Windows as quoting is not enough to avoid shell expension pallets/click#2359Could be revisited if shiny for python opt-out shell expansion
closes #12059
Not sure if we can add test.