Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Jun 28, 2022

I think this is needed for this to correctly work

const val = registryReadString(r, key, value);
if (val !== undefined) {
return val;
}

Otherwise val will be a Promise and val !== undefined not what it expected

This issue appeared following 966fd98 as HKCU does not have the key, but HKLM does. At least on my computer as I got

❯ quarto check knitr
[>] Checking R installation...........(None)

      Unable to locate an installed version of R.
      Install R from https://cloud.r-project.org/

This does not solve probably #1225 but related to its debugging.

Adding an await here makes sense right ?

@cderv cderv requested a review from jjallaire June 28, 2022 11:23
@jjallaire jjallaire merged commit 0909b69 into main Jun 28, 2022
@jjallaire jjallaire deleted the windows-registry-r branch June 28, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants