ask knitr to hold/coalesce echos when renderings is set#12402
Merged
gordonwoodhull merged 2 commits intomainfrom Mar 28, 2025
Merged
ask knitr to hold/coalesce echos when renderings is set#12402gordonwoodhull merged 2 commits intomainfrom
gordonwoodhull merged 2 commits intomainfrom
Conversation
gordonwoodhull
force-pushed
the
bugfix/renderings-knitr-hold-echos
branch
2 times, most recently
from
607eb10 to
41b0120
Compare
gordonwoodhull
force-pushed
the
bugfix/renderings-knitr-hold-echos
branch
from
41b0120 to
b73b83c
Compare
Member
Author
|
Thanks @cderv! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12362
As suggested by @cderv, add a hook to knitr to hold/coalesce echos when
renderingsis set, so that echos are not interspersed with plot outputs.This makes knitr consistent with other engines, and allows all the code to be displayed with
renderings: [light, dark].