Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Aug 26, 2025

Important

This is a PR against v1.7 for patch release

Companion PR to #13277

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Aug 26, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@cderv
Copy link
Collaborator Author

cderv commented Aug 26, 2025

@cderv
Copy link
Collaborator Author

cderv commented Aug 26, 2025

This is the error we see now
image

Also show in Annotation
image

This means we do have a problem with v1.7 branch with quarto-preview.js 😟

It does not seem to be a build problem, but a copy problem to the expected place

dist/quarto-preview.js   444.41 KiB / gzip: 132.15 KiB
[vite-plugin-static-copy:build] Cannot copy 'D:\a\quarto-cli\quarto-cli\src\webui\quarto-preview\dist\quarto-preview.js' to a subdirectory of itself, 'D:\a\quarto-cli\quarto-cli\src\resources\preview\quarto-preview.js'.
[vite-plugin-static-copy] Copy count was not set.
error during build:
Error: Cannot copy 'D:\a\quarto-cli\quarto-cli\src\webui\quarto-preview\dist\quarto-preview.js' to a subdirectory of itself, 'D:\a\quarto-cli\quarto-cli\src\resources\preview\quarto-preview.js'.
    at Object.checkParentPaths (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/fs-extra@11.3.1/node_modules/fs-extra/lib/util/stat.js:109:11)
    at eventLoopTick (ext:core/01_core.js:175:7)
    at async Object.copy (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/fs-extra@11.3.1/node_modules/fs-extra/lib/copy/copy.js:29:3)
    at async copyAll (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/vite-plugin-static-copy@0.13.1/node_modules/vite-plugin-static-copy/dist/index.js:530:7)
    at async Object.writeBundle (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/vite-plugin-static-copy@0.13.1/node_modules/vite-plugin-static-copy/dist/index.js:942:19)
    at async Promise.all (index 0)
    at async PluginDriver.hookParallel (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/rollup@2.79.1/node_modules/rollup/dist/es/shared/rollup.js:22676:9)
    at async file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/rollup@2.79.1/node_modules/rollup/dist/es/shared/rollup.js:23804:13
    at async catchUnfinishedHookActions (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/rollup@2.79.1/node_modules/rollup/dist/es/shared/rollup.js:23126:20)
    at async doBuild (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/vite@3.2.6/node_modules/vite/dist/node/chunks/dep-1889fec9.js:45792:22)

(cherry picked from commit 97e87d1)
@cderv
Copy link
Collaborator Author

cderv commented Aug 26, 2025

Let's fix on its own PR

@cderv cderv marked this pull request as ready for review August 26, 2025 16:32
@cderv cderv merged commit 753a357 into v1.7 Aug 26, 2025
3 of 5 checks passed
@cderv cderv deleted the backport/gha/check-preview-js branch August 26, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants