Fix TinyTeX detection for empty directories #13743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quarto was incorrectly detecting TinyTeX when ~/.TinyTeX/ directory existed without binaries, reporting "Version: undefined" but marking the check as OK. This prevented fallback to valid TinyTeX installations in the system PATH. The detection logic now validates both that the bin directory exists and contains the tlmgr binary before reporting TinyTeX as available. Fixes #13730
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
|
@mcanouil would you be able to test this in your use case ? Do you need a quarto.exe for it for easier testing ? The logic is quite simple as discussed. |
Collaborator
Author
|
You'll find the bundles as artifacts of this run: https://github.com/quarto-dev/quarto-cli/actions/runs/19828995939 If you can test it in your context. Thank you! |
Collaborator
|
I'll try to do that tomorrow or Wednesday. |
Collaborator
|
It works in the setup in which I discovered the issue. docker run --rm -it --platform linux/amd64 --user vscode \
ghcr.io/mcanouil/quarto-codespaces:release-202511122111 \
bash -lcd ~
git clone --branch fix/issue-13730 https://github.com/quarto-dev/quarto-cli
cd quarto-cli
sudo ./configure.sh
quarto check install |
Collaborator
Author
|
Cool thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
~/.TinyTeX/directory exists without actual binaries,quarto check installreports:The check passes with "Version: undefined", preventing fallback to valid TinyTeX installations in the system PATH.
Root Cause
The detection logic in
src/tools/impl/tinytex-info.tsonly verified the install directory exists, not the binaries within.hasTinyTex()checked only if~/.TinyTeX/existstinyTexBinDir()constructed bin paths without validation on Linux/Mac (Windows already validated)Fix
Added two-level validation:
tinyTexBinDir()now validates the bin directory exists before returning paths on Linux/Mac, matching Windows behaviorhasTinyTex()verifies the tlmgr binary exists within the bin directoryThis ensures Quarto only reports TinyTeX as available when it contains working binaries, allowing proper fallback to PATH installations when the home directory installation is incomplete.
Fixes #13730