Fix profile image's top padding in compact view (#14211)#14280
Open
rnd195 wants to merge 2 commits intoquarto-dev:mainfrom
Open
Fix profile image's top padding in compact view (#14211)#14280rnd195 wants to merge 2 commits intoquarto-dev:mainfrom
rnd195 wants to merge 2 commits intoquarto-dev:mainfrom
Conversation
When opening a website's "About" page in compact view (with a narrow browser window), the `profile.jpg` image has no top padding in the `trestles`, `marquee` and `broadside` templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14211 - Add top padding to the profile image on a website's about page in compact view (trestles, marquee, broadside)
Description
I modify three lines in the
src/resources/projects/website/about/about.scssfile, all related to the profile image's top padding in compact view.LINE 175:
In the
trestlestemplate, I set the top padding to 3em to match the top padding value in non-compact view from here:quarto-cli/src/resources/projects/website/about/about.scss
Line 170 in e626825
I am not sure why it was previously explicitly set to 0, but found no issues changing it to 3em
LINES 227 & 264:
marqueeandbroadsidetemplates, I set the top padding to 14px, which comes from a default content padding value (which is used in non-compact view) from this linequarto-cli/src/resources/projects/website/navigation/quarto-nav.scss
Line 37 in e626825
Verification
quarto create project blog test title_quarto.yml, change the theme fromcosmotoceruleanfor better visibilityabout.qmd, choose one oftrestles,marquee, orbroadsidetemplatesquarto preview about.qmdin the created project's root directoryChecklist
I have (if applicable):