Skip to content

Conversation

@schrimpf
Copy link
Contributor

@schrimpf schrimpf commented Jan 18, 2023

Begin to address #3965

These are simple ports of the existing Python tests. I don't know enough typescript to add anything more novel. In particular, on my machine, the tests do not trigger #2539 , even though running quarto render julia.qmd from a shell fails unless the --no-execute-daemon option is added.

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog

@cscheid
Copy link
Collaborator

cscheid commented Jan 20, 2023

Thank you! This is already helpful. One way to attempt to trigger #2539 is to brute-force a call to quarto render julia.cmd from a top-level Deno.test(). We try hard to keep to our own test library to manage (eg) asset cleanups but for sporadic checks like this, that's worth it.

@jjallaire
Copy link
Collaborator

Note that I've received the contributor agreement for this

@cscheid cscheid merged commit f819584 into quarto-dev:main Jan 26, 2023
@cderv cderv mentioned this pull request Jan 26, 2023
16 tasks
cscheid pushed a commit that referenced this pull request Jan 31, 2023
* Added tests for Julia

These are simple ports of existing Python tests.

* Added Julia install and setup to test-smokes workflow.

* fix julia-subfig test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants