Correct invalid pattern for http URLs#4993
Merged
Merged
Conversation
cderv
reviewed
Mar 28, 2023
dragonstyle
force-pushed
the
bugfix/4964
branch
from
806ad36 to
2337b75
Compare
cderv
approved these changes
Mar 28, 2023
Member
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
And correctly working for me on Windows now!
Thanks !
Both of these patterns are incorrect- they intend to match urls that start with http or https. Fixes #4964 The LUA resource discovery is a new addition this release, so this represents a regression.
dragonstyle
force-pushed
the
bugfix/4964
branch
from
2337b75 to
7a9f45a
Compare
cscheid
approved these changes
Mar 28, 2023
Member
cscheid
left a comment
cscheid
left a comment
There was a problem hiding this comment.
Yup, that looks correct to me too.
Should we do a more general review of our patterns to see if we have more instances of [] doing unexpected things?
Member
Probably. I did a quick search in VSCODE and I think these are the only ones. Double checking is often a good idea! |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both of these patterns are incorrect- they intend to match urls that start with http or https.
Fixes #4964
The LUA resource discovery is a new addition this release, so this represents a regression.
Thanks to @cderv for tracking down this issue!