Fix duplicate version in older releases table#1972
Merged
Conversation
The version 1.8.27 entry was appended twice to _download-older.yml, causing it to appear as a duplicate row on the download page.
yaml12 will be used in release-notes.R for idempotent updates to _download-older.yml, preventing duplicate entries.
Replace blind cat(append=TRUE) with yaml12-based read/check/write. The script now parses the existing YAML, checks if the version is already present, and either updates it or appends a new entry. This prevents duplicate entries if the script runs twice.
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1972.quarto.org |
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
* Fix duplicate 1.8.27 entry in older releases listing The version 1.8.27 entry was appended twice to _download-older.yml, causing it to appear as a duplicate row on the download page. * Add yaml12 dependency for structured YAML handling yaml12 will be used in release-notes.R for idempotent updates to _download-older.yml, preventing duplicate entries. * Use yaml12 for idempotent upsert in release-notes.R Replace blind cat(append=TRUE) with yaml12-based read/check/write. The script now parses the existing YAML, checks if the version is already present, and either updates it or appends a new entry. This prevents duplicate entries if the script runs twice. (cherry picked from commit afe4421)
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Older Releases" table on the download page shows version 1.8.27 twice.
Root Cause
tools/release-notes.Rusescat(..., append = TRUE)to add entries todocs/download/_download-older.yml. If the script runs twice (e.g. re-runningthe release checklist), it blindly appends a duplicate with no guard.
Fix
_download-older.ymlcat(append)approach with yaml12-based upsert: the script nowparses the existing YAML, checks if the version is already present, and
either updates it or appends a new entry