Terminate Quarto preview when terminal is closed externally#947
Merged
Terminate Quarto preview when terminal is closed externally#947
Conversation
Collaborator
|
This change looks good to me. Thank you for the clear explanation of the problem and solution. I didn't test this PR locally, as I understand it will be verified that the issue was resolved separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#13006.
When a user closes the Quarto Preview terminal via the trash icon, the underlying Quarto process was not terminated cleanly. This left behind intermediate
.quarto_ipynbfiles, and repeated previews would accumulate*.quarto_ipynb_1,*.quarto_ipynb_2, etc.This was happening because VS Code's trash icon sends
SIGHUPto the shell process only. Quarto, as a child process, typically survives as an orphan and never receives the signal needed to trigger cleanup. Ctrl+C works because it sendsSIGINTto the entire foreground process group.This PR registers an
onDidCloseTerminallistener inPreviewManager. When the preview terminal is closed by any external means, it sends the same HTTP termination request thatkillPreview()already uses, giving Quarto the chance to clean up before it exits. To avoid a duplicate request when the extension itself kills the terminal,this.terminal_is cleared beforekillTerminal()is called, so the event handler's identity check short-circuits.