Skip to content

chore: remove cargo test job from ci workflow#2436

Merged
benfdking merged 1 commit intomainfrom
claude/remove-cargo-test-action-69sf0
Mar 17, 2026
Merged

chore: remove cargo test job from ci workflow#2436
benfdking merged 1 commit intomainfrom
claude/remove-cargo-test-action-69sf0

Conversation

@benfdking
Copy link
Collaborator

Summary

Removed the test-cargo job from the GitHub Actions PR workflow. This job was responsible for running Rust cargo tests and Python dependency checks in the CI pipeline.

Changes

  • Deleted the entire test-cargo job definition which included:
    • PostgreSQL service configuration
    • Python virtual environment setup and dependency installation
    • Rust toolchain and cache setup
    • Cargo test execution for CLI crate and all workspace crates
    • Git diff verification step

Rationale

The cargo test job has been removed from the PR workflow, likely in favor of alternative testing mechanisms or consolidation of CI jobs. The bazel-lint job remains as the primary CI check.

https://claude.ai/code/session_01JPLR21qtJhbKre9a4rqnzb

The cargo test job is now redundant as it's covered by the Bazel
test targets (bazel test //:cargo_test and //...).

https://claude.ai/code/session_01JPLR21qtJhbKre9a4rqnzb
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@benfdking benfdking changed the title Remove Cargo test job from CI workflow chore: remove Cargo test job from CI workflow Mar 17, 2026
@benfdking benfdking changed the title chore: remove Cargo test job from CI workflow chore: remove cargo test job from ci workflow Mar 17, 2026
@benfdking benfdking merged commit 960de9e into main Mar 17, 2026
24 of 26 checks passed
@benfdking benfdking deleted the claude/remove-cargo-test-action-69sf0 branch March 17, 2026 12:29
@github-actions
Copy link
Contributor

Benchmark for 37fa20f

Click to view benchmark
Test Base PR %
DepthMap::from_parent 52.9±0.43µs 53.3±1.61µs +0.76%
fix_complex_query 11.6±0.08ms 11.6±0.06ms 0.00%
fix_superlong 166.3±7.03ms 164.1±5.34ms -1.32%
parse_complex_query 4.1±0.06µs 4.1±0.05µs 0.00%
parse_expression_recursion 7.0±0.06µs 7.1±0.61µs +1.43%
parse_simple_query 1039.1±13.16ns 1051.2±28.52ns +1.16%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants