Skip to content
This repository was archived by the owner on Mar 17, 2024. It is now read-only.

Started adding unit tests into the Client. #127

Closed
tidusjar wants to merge 7 commits intoquasar:masterfrom
tidusjar:UnitTests
Closed

Started adding unit tests into the Client. #127
tidusjar wants to merge 7 commits intoquasar:masterfrom
tidusjar:UnitTests

Conversation

@tidusjar
Copy link
Copy Markdown
Contributor

Hello,

I have started to add some unit tests into the Client. I will proceed with this and eventually start adding some to the Server!

This is using NUnit 3 and Autofixture.

I just thought it would be very useful to have some of these components wrapped around in Unit tests so we don't break anything.

(Note: if I have done the process incorrect apologies! It's my first contribution).

@tidusjar
Copy link
Copy Markdown
Contributor Author

Can we please add into the AppVeyor.yml ?
http://www.appveyor.com/blog/2014/03/18/about-nuget-package-restore

Or this:
http://www.appveyor.com/docs/nuget#restoring-nuget-packages-before-build

This will then allow my branch to build :(

before_build:
- nuget restore

@DragonzMaster
Copy link
Copy Markdown
Contributor

i am really ashamed to ask this but what is it used for ?

@tidusjar
Copy link
Copy Markdown
Contributor Author

DragonzMaster, this is for unit testing http://en.wikipedia.org/wiki/Unit_testing . I am working on getting the references and Nuget packages working right now so the Build passes. Checkout my branch and run the tests and you will see what they do. :)

@bitterypaul
Copy link
Copy Markdown

thanks for the unit test contribution. btw check out all open issues and please contribute more. thanks

@tidusjar
Copy link
Copy Markdown
Contributor Author

BitteryPaul, I want to contribute more so I will take a look after I get this build working.

@bitterypaul
Copy link
Copy Markdown

wonderful. thecbuild is successful. great work @tidusjar

@tidusjar
Copy link
Copy Markdown
Contributor Author

Thanks. It was a pain getting Nuget packages to resolve when we have none already! All the work is now done for Nuget!

@yankejustin
Copy link
Copy Markdown
Contributor

It is funny but I was just thinking about this. This is especially necessary for the keylogger and file transfering to ensure the data is being transferred correctly! :)

@yankejustin
Copy link
Copy Markdown
Contributor

@MaxXor This is very important for these data-critical tasks! This makes life easy. 💯

@tidusjar
Copy link
Copy Markdown
Contributor Author

@yankejustin I plan adding more tests into the solution! It makes things 10000x easier regarding maintainability and reducing bugs

MaxXor added a commit that referenced this pull request May 13, 2015
@MaxXor
Copy link
Copy Markdown
Contributor

MaxXor commented May 13, 2015

Hey,
can you add your unit tests to the following unit testing project I've created? Thanks!

@MaxXor MaxXor closed this May 13, 2015
@tidusjar
Copy link
Copy Markdown
Contributor Author

@MaxXor Just wondering why you are not using NUnit? It's a lot more flexible than MSTest. Any why are we not using AutoFixture? The main benefit of AF is that we can quickly mock up populated classes with 1 line.

@tidusjar tidusjar deleted the UnitTests branch May 13, 2015 17:24
@MaxXor
Copy link
Copy Markdown
Contributor

MaxXor commented May 13, 2015

At the moment I don't see a need for this, the Client supports some Helper methods which are useful. I also want to keep the dependencies as low as possible.

@tidusjar
Copy link
Copy Markdown
Contributor Author

@MaxXor Ok no problem. I'm just saying there are a lot of advantages. Should I be doing this in the Master or Dev branch?

@MaxXor
Copy link
Copy Markdown
Contributor

MaxXor commented May 13, 2015

Master please. :)

@tidusjar
Copy link
Copy Markdown
Contributor Author

Can you also create a project for the Server? I'll start adding some to that too :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants