This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Separated the command handlers#139
Merged
MaxXor merged 2 commits intoquasar:masterfrom May 16, 2015
yankejustin:SeparateCommandHandlers
Merged
Separated the command handlers#139MaxXor merged 2 commits intoquasar:masterfrom yankejustin:SeparateCommandHandlers
MaxXor merged 2 commits intoquasar:masterfrom
yankejustin:SeparateCommandHandlers
Conversation
Divided the server's CommandHandler class into partial classes.
Divided the client's CommandHandler class into partial classes.
Contributor
|
Thanks, makes it much easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes:
These changes do not modify or change the function of the code.
These changes merely improve the code so it is easier to use, read, and change.
Reason:
I realized that, eventually, I was reading and constantly having to waste time scrolling through long classes of the server and client's CommandHandler.cs
These two classes were each ~1,000 lines. I reasoned that these should be separated. Just to help us programmers out so we don't have to constantly spend time scrolling and scrolling. As a bonus, logic is separated.
Will this affect the code output?:
No. The resulting code is not affected. Because these different Command Handler files are partial classes, that means that when it is compiled, these files will be treated as if they are together.