This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Improvements#161
Merged
MaxXor merged 8 commits intoquasar:masterfrom May 21, 2015
yankejustin:Improvements
Merged
Conversation
Break out of the loop when a subtype's derived type is found to match.
FileSplit provides more meaningful exceptions.
Moved string array for file size units to a class-level const string array for performance.
More meaningful exception is thrown for the Client's Helper class' GetDiffDesktop method.
Instead of using const, we must use static readonly...
Remote Desktop now leaks significantly less memory on the Client. GetDiffDesktop was unlocking bits only if an exception was thrown!
It is not GetDiffDesktop's responsibility to dispose of bmpRes. Just call UnlockBits, then return the Bitmap.
Contributor
Author
|
As a little note, I would just like to say my goal is to remove every occurrence of the phrase "throw new Exception". I just find it far too broad and meaningless. That will be later, though. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions
- Exceptions provide better responses for the server (providing more-accurate status updates). It also makes debugging a bit easier - Add types to serializer faster. When a matching subtype's derived type is found, break out of the loop.Performance
- Big reduction on memory consumption when using Remote Desktop (for Client). - Faster retrieval of file size.