This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Improvements#191
Merged
MaxXor merged 2 commits intoquasar:masterfrom May 25, 2015
yankejustin:Improvements
Merged
Conversation
Instead of wasting lots of time creating a string from a char array, creating a string from another char array, concatenating them both into a new string, and casting the keychar to a string to see if the string contains it, make the operation natural and very efficient by creating a new char array that has both invalid characters and making sure the illegal character array does not contain the element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for the FrmBuilder Form's code
1. Removed some repetitive code by placing in a method. 2. Using LINQ, efficiently compute a mathematical union for the two char arrays and use that to test against detection of illegal characters. Much more efficient and no more wasted time casting. :)