This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Conversation
Merge with master branch
Correctly disposes of the Bitmaps used in both of the CommandHandlers.
Removed a label and implemented a more-common do-while loop for retry functionality.
Placed TcpClient in a try-finally to make sure it will never linger if it (likely) cannot connect successfully.
Disposes of the memory stream created in the server's helper class that converts an image.
Disposed of any additional resources that weren't being disposed after closing the shell session. Also told the garbage collector to suppress finalization if we have already told the session to close. No reason to clean the object twice! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.