This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Better server validation#259
Merged
MaxXor merged 4 commits intoquasar:masterfrom Jun 3, 2015
yankejustin:ClientInputSafety
Merged
Better server validation#259MaxXor merged 4 commits intoquasar:masterfrom yankejustin:ClientInputSafety
MaxXor merged 4 commits intoquasar:masterfrom
yankejustin:ClientInputSafety
Conversation
Added more restrictive validation for the "System" handlers.
Added more restrictive validation for the "Surveillance" handlers.
Added more restrictive validation for the "Misc" Handlers.
If the packet's "Filename" property is null or empty, we can avoid making an unnecessary string for the downloadPath by placing the validation above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
A client should never have the ability to break the server (cause an uncaught exception) by sending packets with invalid or otherwise unusable data.
Changes
- Added more restrictive validation to ensure usable information by the received packets on the handlers before use. This makes sure that a client that may make a strange request with bad data without causing a server crash.