Skip to content
This repository was archived by the owner on Mar 17, 2024. It is now read-only.

Fixed Remote Desktop Issue#27

Closed
yankejustin wants to merge 8 commits intoquasar:masterfrom
yankejustin:master
Closed

Fixed Remote Desktop Issue#27
yankejustin wants to merge 8 commits intoquasar:masterfrom
yankejustin:master

Conversation

@yankejustin
Copy link
Copy Markdown
Contributor

Fixed an issue where Remote Desktop would not work (threw infinite InvalidOperationExceptions) because cbMonitors.SelectedIndex was trying to be accessed on a different thread.

Please note that the only commit I wish to be accepted is the first "Fixed Remote Desktop Issues"! The other commits were ones that were merely tests that I have reverted.
Again, only the first commit is the one that I wish to merge.

Notable issues with the Remote Desktop:

  1. Sucks down memory on the Client - Yes, the Garbage Collector will eventually collect the unused resources that have gone astray. However, it does so every second (low-blow to the performance train). It could be very negative to the user if the machine being used is rather poor. The memory allocations will stay around 200MB to 700MB while running the Remote Desktop tool. It will cycle up and down those limits as fast as 3/4 of a second to 1 second...
  2. Does not yet work with multiple monitors.
    --> Simply does not obtain the desktop from a monitor other than the primary.
    --> When viewing the desktop on a monitor smaller than the server's primary monitor, the images that are displayed back to the Remote Desktop Form are visibly distorted because of how the image is transformed when received.

Merge head respository with this branch
Fixed an issue where Remote Desktop would not work (threw infinite
InvalidOperationExceptions) because cbMonitors.SelectedIndex was trying
to be accessed on a different thread.
Moved code that gets the SelectedIndex inside the MethodInvoker.
Correctly get rid of the Form by disposing instead of setting it to
null.
Dispose of unused Bitmaps when handling the remote desktop response.
Unlocked the bits for the Bitmaps used in the finally block instead of
the catch because they should always be unlocked; not just if something
in the method fails.
This reverts commit d609b63.
This reverts commit cfdebc0.
@MaxXor
Copy link
Copy Markdown
Contributor

MaxXor commented Mar 19, 2015

Could you please make a new pull request? This makes it a mess with all these Reverts. You can do this by deleting your fork and creating it again, but do a backup of your files before.

I am aware of the Remote Desktop issues... will see what I can do.

@MaxXor
Copy link
Copy Markdown
Contributor

MaxXor commented Mar 19, 2015

I have two monitors, but the Remote Desktop is working fine on both of them (both 1920x1080). I can view other monitors than the primary one... any steps to reproduce?

@MaxXor
Copy link
Copy Markdown
Contributor

MaxXor commented Mar 19, 2015

@yankejustin
Copy link
Copy Markdown
Contributor Author

Thank you for the commentary.
Also, thank you for telling me how to not make a mess of the fork. I haven't worked with Subversion much outside of TortoiseSVN!

As for the Remote Desktop issue with the image being distorted, my primary monitor is (1920x1080), but my secondary monitor is (1080x760). If I have the Remote Desktop open and maximized on my secondary and it is analyzing my primary, the image won't scale correctly and will mess some pixels up. The Remote Desktop is only showing a black screen when I try to use it on my second monitor. When I can tonight, I will see if it is fixed if I set my smaller monitor to primary.

@yankejustin
Copy link
Copy Markdown
Contributor Author

I had also reverted that commit about disposing the Form instead because I figured that setting it to null was intentional.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants