This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Removed unused Firefox stuff#342
Closed
Rottweiler wants to merge 1 commit intoquasar:masterfrom
Rottweiler:master
Closed
Removed unused Firefox stuff#342Rottweiler wants to merge 1 commit intoquasar:masterfrom Rottweiler:master
Rottweiler wants to merge 1 commit intoquasar:masterfrom
Rottweiler:master
Conversation
|
Can you hold off on this I'm deep into it :D Got a whole bunch of fixes for this |
Author
|
This is very messy code, but this example currently works (Visual Basic .NET) https://raw.githubusercontent.com/rotthh/PREC/master/prec.vb |
Author
|
All right, should I close the pull request? |
|
Yes, please :) I've tested earlier versions and those calls are needed to load the DLLs properly |
Author
|
Sure. |
|
Thanks! When I make the PR, would you be able to test it? |
Author
|
Absolutely |
|
Awesome, thank you! #343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused/not needed Firefox recovery libs+functions+calls
Firefox recovery currently fails at LoadLibrary->nss3.dll, (or alternately NSS_Init call). I got it working on Windows 10 x64 when providing hardcoded path to install directory + compiling under x86