This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Code Consistency and Clarity, Performance, and a Small Fix#48
Merged
MaxXor merged 5 commits intoquasar:masterfrom Apr 8, 2015
yankejustin:master
Merged
Code Consistency and Clarity, Performance, and a Small Fix#48MaxXor merged 5 commits intoquasar:masterfrom yankejustin:master
MaxXor merged 5 commits intoquasar:masterfrom
yankejustin:master
Conversation
Made sure the server disposed of the Socket when Server.Listen(ushort) is called if the Socket was created before (called Server.Listen(ushort) previously but stopped listening).
If the endpoint was null, the loop would break anyways, not allowing up to 5 retries (only got 1 try).
Made some code more consistent to the code in the solution.
Slightly improved performance for the SafeQuickLZ on the server and client, code clean-up, and consistency improvements.
Compacted the validation on frmBuilder's btnBuild_Click(object, EventArgs) method. This is a slight optimization, but it does help remove the repetitive else statements.
MaxXor
added a commit
that referenced
this pull request
Apr 8, 2015
Code Consistency and Clarity, Performance, and a Small Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a rather small memory leak with the Server Socket potentially not being disposed of correctly, fixed a loop in the Server's 'UPnP' class that only gave one chance for a valid end-point to be found, improved the consistency in some parts of the code, optimized both of the 'SafeQuickLZ' class's Compression method, and compacted the Builder Form's 'Build' method to improve speed and to reduce redundancy .